[FIX] Fixes overflow in Administration panel #19943
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hey @aKn1ghtOut thanks a lot for the help! Unfortunately, your fix is not really a good way to do it, since the header should remain static while we scroll. We had recently introduced a new (js) scroll to rocket.chat, and the fix is a little different. You can take a look at my PR #19944 if you wanna see how I did. Anyway, thanks for your comprehension! |
Contributor
Author
|
Thanks a lot for @gabriellsh. I did expect this, and to learn the right way of doing things here was most important. Did open the PR mostly because I was able to pinpoint the exact problem with a bit of time, so that could help someone to actually solve it faster! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue(s)
Fixes issue #19939
In the administration panel sidebar, the last item is cut off because of overflow. This happens because the Header takes 60px of height(calculated), while the Sidebar.Content element below it has a maximum height of "100%". Hence, he content element expands to be equal to the height of the body, but the lat 60px of it are then cut-off, as the effective height of both the elements together becomes (100% + 60px)
Proposed changes
The Sidebar Header in the administration panel was shifted from outside the Sidebar.Content box to inside it. Now, the Content having a maximum height of 100% does not become a problem as it is the calculated height of both the content and the header together, and there is no overflow.
Steps to test or reproduce